Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

This page describes the behaviour behavior of the DevSensei Ship/Show/Ask feature in details. Refer to About Ship/Show/Ask PR workflow for description and motivation of Ship/Show/Ask.

(The content of this page only applies if you enabled full Ship/Show/Ask support on your project or repository. Please refer to the Getting started - DC page to enable it.)

Ship/Show/Ask

...

behavior summary

All pull requests are characterised characterized by DevSensei in 5 different categories. The behaviour behavior of these categories is summurised summarized in the table below.

Auto-merge ?

Number of require approvals

No Ship/Show/Ask

No

0

Ask>=n

No

n

Show

Yes

0

Show>=n

Yes

n

Ship

Yes

0 (And Skip Code Owners)

Info

Note that when you are not using full Ship/Show/Ask support, the Auto merge [Auto] behaviour behavior is equivalent to [Show].

Ask pull requests

...

To initiate an [Ask>=n] pull request, the user must select Manual merge and ask to require a certain number of approvals via the dedicated dropdowndrop-down.

...

Show pull requests

You can configure Pull Requests to be merged automatically, optionally requiring a certain number of approvals.

...

  • a [Show] pull request doesn’t require any approvals to be merged. However, if Code Owners requires approvals for that same pull request, they will not be skipped. Therefore the pull request will not be automatically merged before Code Owners merge checks are fullfilledfulfilled

  • a [Show>=2] pull request will require two approvals, regardless of who they are coming from. If for its part, Code Owners requires 3 approvals as merge check, then in total only 3 approvals will be necessary. The same applies for [Ask>=2], the difference being that Ask does not auto-merge

  • a [Ship] pull request will skip assignment of Code Owners. This is inline with the philosophy of Ship/Show/Ask: Ship pull request are meant for tiny and trivial changes to your repository. Such changes will be more effective if you don’t bother other team members to carry them through.

...

DevSensei will check that a pull request can be auto-merged everytime every time an impactful change happens to the pull request. For example, a new task compleatedcompleted, a new approval, a finished build or a change in the title. However, it will never do so less than 20 seconds after the creation of the pull request, leaving you a time window to change the pull request title (or delete the pull request) if you accidentally used the wrong one (see “I accidentally create a pull request in the wrong category, can I do something about it?”).

...